[webkit-reviews] review canceled: [Bug 104840] REGRESSION(137336): Generated run-ins are not placed correctly : [Attachment 179125] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 12 14:51:47 PST 2012


Elliott Sprehn <esprehn at chromium.org> has canceled Elliott Sprehn
<esprehn at chromium.org>'s request for review:
Bug 104840: REGRESSION(137336): Generated run-ins are not placed correctly
https://bugs.webkit.org/show_bug.cgi?id=104840

Attachment 179125: Patch
https://bugs.webkit.org/attachment.cgi?id=179125&action=review

------- Additional Comments from Elliott Sprehn <esprehn at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179125&action=review


> Source/WebCore/rendering/RenderBlock.cpp:1836
> +    ASSERT(runIn->node());

Hmm, it seems this simplification is not possible because things like
RenderButton::addChild create anonymous blocks with style()->display(). I had
thought there was no way to create an anonymous run-in, but it appears I'm
wrong.


More information about the webkit-reviews mailing list