[webkit-reviews] review granted: [Bug 104832] [BlackBerry] Ensure InRegionScrollableArea is valid before using. : [Attachment 179123] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Mike Lattanzio
<mlattanzio at rim.com>'s request for review:
Bug 104832: [BlackBerry] Ensure InRegionScrollableArea is valid before using.
https://bugs.webkit.org/show_bug.cgi?id=104832

Attachment 179123: Patch
https://bugs.webkit.org/attachment.cgi?id=179123&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179123&action=review


Please reupload with "Reviewed by antonio Gomes" and just request cq to land
it.

r+, some nits though.

> Source/WebKit/blackberry/Api/InRegionScroller.cpp:420
> +bool
InRegionScrollerPrivate::isValidScrollableLayerWebKitThread(WebCore::LayerWebKi
tThread* layerWebKitThread) const

WebCore:: is needed?

> Source/WebKit/blackberry/Api/InRegionScroller.cpp:428
> +    for (unsigned i = 0; i < m_activeInRegionScrollableAreas.size(); i++)
> +	   if
(static_cast<InRegionScrollableArea*>(m_activeInRegionScrollableAreas[i])->cach
edScrollableLayer() == layerWebKitThread)
> +	       return true;
> +

for need {}

++i is preferred.

> Source/WebKit/blackberry/Api/InRegionScroller.cpp:432
> +bool InRegionScrollerPrivate::isValidScrollableNode(WebCore::Node* node)
const

WebCore is needed?

> Source/WebKit/blackberry/Api/InRegionScroller.cpp:439
> +    for (unsigned i = 0; i < m_activeInRegionScrollableAreas.size(); i++)
> +	   if
(static_cast<InRegionScrollableArea*>(m_activeInRegionScrollableAreas[i])->cach
edScrollableNode() == node)
> +	       return true;

ditto

++i is preferred.