[webkit-reviews] review granted: [Bug 104721] CachedResources should hang on to stripped fragment identifiers : [Attachment 179116] clear fragment after use, add FIXME

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 104721: CachedResources should hang on to stripped fragment identifiers
https://bugs.webkit.org/show_bug.cgi?id=104721

Attachment 179116: clear fragment after use, add FIXME
https://bugs.webkit.org/attachment.cgi?id=179116&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=179116&action=review


r=me with one optional suggested improvement for the ChangeLog.

> Source/WebCore/loader/cache/CachedResourceLoader.cpp:-445
> -    if (request.resourceRequest().url() != url)
> -	   request.mutableResourceRequest().setURL(url);

It might be worthwhile to add a note to ChangeLog to explain the deletion of
these two lines. With explanation, I can see that what they accomplish is done
elsewhere in the patch but it's hard to tell otherwise.