[webkit-reviews] review denied: [Bug 104807] Adds support for fromCharCode intrinsic : [Attachment 179038] Adds Support for fromCharCode intrinsic

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied  review:
Bug 104807: Adds support for fromCharCode intrinsic
https://bugs.webkit.org/show_bug.cgi?id=104807

Attachment 179038: Adds Support for fromCharCode intrinsic
https://bugs.webkit.org/attachment.cgi?id=179038&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=179038&action=review


> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:2029
> +    speculationCheck(Uncountable, JSValueRegs(), NoNode,
m_jit.branch32(MacroAssembler::AboveOrEqual, propertyReg,
TrustedImm32(0x100)));

I know that the other string intrinsically do this as well but I would rather
we not perpetuate it. Your patch could easily be a huge regression if someone
does a Unicode fromcharcodeat that dominates a look. Please switch this to a
slow path invocation.