[webkit-reviews] review granted: [Bug 104807] Adds support for fromCharCode intrinsic : [Attachment 179038] Adds Support for fromCharCode intrinsic

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Vahag <vaag at ispras.ru>'s request for
review:
Bug 104807: Adds support for fromCharCode intrinsic
https://bugs.webkit.org/show_bug.cgi?id=104807

Attachment 179038: Adds Support for fromCharCode intrinsic
https://bugs.webkit.org/attachment.cgi?id=179038&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=179038&action=review


Code looks good to me, but you need to make sure you have a real change log. 
Once you've got that re-upload and i'll re-review and land.

> Source/JavaScriptCore/ChangeLog:8
> +	   Need a short description (OOPS!).
> +	   https://bugs.webkit.org/show_bug.cgi?id=104807
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Additional information of the change such as approach, rationale.
Please add per-function descriptions below (OOPS!).

Alas you need a real change log.