[webkit-reviews] review denied: [Bug 104774] SET_VAR, SET_BORDERVALUE_COLOR macro don't need semicolon(; ) at the end of the line : [Attachment 178990] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 12 10:45:18 PST 2012


Alexey Proskuryakov <ap at webkit.org> has denied Jaehun Lim
<ljaehun.lim at samsung.com>'s request for review:
Bug 104774: SET_VAR, SET_BORDERVALUE_COLOR macro don't need semicolon(;) at the
end of the line
https://bugs.webkit.org/show_bug.cgi?id=104774

Attachment 178990: Patch
https://bugs.webkit.org/attachment.cgi?id=178990&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I don't think that this is an improvement. Statements should end with
semicolons for consistency, otherwise the code looks wrong to humans.

If you really want to avoid redundant semicolons, please change the macros to
require them.


More information about the webkit-reviews mailing list