[webkit-reviews] review denied: [Bug 104443] [BlackBerry] Update Media Controls for BlackBerry Platform : [Attachment 179061] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has denied  review:
Bug 104443: [BlackBerry] Update Media Controls for BlackBerry Platform
https://bugs.webkit.org/show_bug.cgi?id=104443

Attachment 179061: Patch
https://bugs.webkit.org/attachment.cgi?id=179061&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179061&action=review


Agree with Eric.

> Source/WebCore/html/shadow/MediaControlElements.cpp:440
> +#if PLATFORM(BLACKBERRY)
> +    if (event->type() == eventNames().mousedownEvent) {
> +	   // We do not mute when the media player volume/mute control is
touched
> +	   // on Playbook. Instead we show/hide the volume slider.
> +	   m_controls->toggleVolumeSlider();
> +	   event->setDefaultHandled();
> +	   return;
> +    }
> +#endif

this can be a setting at least, and have its own bug.