[webkit-reviews] review canceled: [Bug 98270] [GTK][WK2] Add API to retrieve a snapshot from a webview : [Attachment 178750] [GTK][WK2] Add API to retrieve a snapshot from a webview https://bugs.webkit.org/show_bug.cgi?id=98270
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 12 10:20:37 PST 2012
Claudio Saavedra <csaavedra at igalia.com> has canceled Claudio Saavedra
<csaavedra at igalia.com>'s request for review:
Bug 98270: [GTK][WK2] Add API to retrieve a snapshot from a webview
https://bugs.webkit.org/show_bug.cgi?id=98270
Attachment 178750: [GTK][WK2] Add API to retrieve a snapshot from a webview
https://bugs.webkit.org/show_bug.cgi?id=98270
https://bugs.webkit.org/attachment.cgi?id=178750&action=review
------- Additional Comments from Claudio Saavedra <csaavedra at igalia.com>
Reviewed by NOBODY (OOPS!).
This adds the GTK+ API necessary to retrieve a snapshot
from a webview asynchronously.
* UIProcess/API/gtk/WebKitError.cpp:
(webkit_snapshot_error_quark):
* UIProcess/API/gtk/WebKitError.h: Add snapshotting error
handling.
* UIProcess/API/gtk/WebKitWebView.cpp:
(GetSnapshotAsyncData):
(didGetSnapshot):
(webkit_web_view_get_snapshot_of_visible_area):
(webkit_web_view_get_snapshot):
(webkit_web_view_get_snapshot_finish): Add the public API.
* UIProcess/API/gtk/WebKitWebView.h: Ditto.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add the new
API to the docs.
* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewSnapshot):
(beforeAll): Add tests for the snapshotting API.
* UIProcess/WebPageProxy.cpp:
(WebKit):
(WebKit::WebPageProxy::getSnapshot):
Add a proxy method to request a snapshot from the web process.
* UIProcess/WebPageProxy.h:
(WebKit):
(WebPageProxy): Ditto.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createSnapshot): Add a method to take a snapshot
for a given region in the WebPage, this method will send a message
back to the UI process with the image handle.
(WebKit):
* WebProcess/WebPage/WebPage.h: Ditto.
(WebPage):
* WebProcess/WebPage/WebPage.messages.in: Add the message for
CreateSnapshot.
More information about the webkit-reviews
mailing list