[webkit-reviews] review granted: [Bug 104819] [GTK][AC][Clutter] The non-composited content is not painted : [Attachment 179071] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Joone Hur
<joone at webkit.org>'s request for review:
Bug 104819: [GTK][AC][Clutter] The non-composited content is not painted
https://bugs.webkit.org/show_bug.cgi?id=104819

Attachment 179071: Patch
https://bugs.webkit.org/attachment.cgi?id=179071&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179071&action=review


> Source/WebKit/gtk/ChangeLog:8
> +	   When Accelerated Compositing is enabled, GraphicsLayers are only
painted.

"only GraphicsLayers are painted"

> Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContext.h:80
> -    WebCore::GraphicsLayer* m_rootGraphicsLayer;
>      GtkWidget* m_rootLayerEmbedder;
> +    OwnPtr<WebCore::GraphicsLayer> m_rootLayer;
> +    OwnPtr<WebCore::GraphicsLayer> m_nonCompositedContentLayer;

I'd like to take this m_rootLayer declaration out of the if/elifs if possible,
since all implementations use this. But this can be done in another patch and
we can grab feedback from mrobinson for that, too.