[webkit-reviews] review granted: [Bug 96481] [Qt][WK2] Add API to find text from page : [Attachment 175200] [Qt][WK2] Add experimental API to find text from page

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 12 08:07:08 PST 2012


Jocelyn Turcotte <jocelyn.turcotte at digia.com> has granted Heikki Paajanen
<heikki.paajanen at palm.com>'s request for review:
Bug 96481: [Qt][WK2] Add API to find text from page
https://bugs.webkit.org/show_bug.cgi?id=96481

Attachment 175200: [Qt][WK2] Add experimental API to find text from page
https://bugs.webkit.org/attachment.cgi?id=175200&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=175200&action=review


Sorry for taking so long, LGTM now.

> Tools/MiniBrowser/qt/BrowserWindow.cpp:106
>  }
> +void BrowserWindow::toggleFind()

Missing newline, please fix before landing or re-upload a patch if you want to
use the commit queue.


More information about the webkit-reviews mailing list