[webkit-reviews] review granted: [Bug 74219] [CSS Regions] Two regions reftests are failing the image match : [Attachment 179000] Patch 3
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 12 07:39:14 PST 2012
Julien Chaffraix <jchaffraix at webkit.org> has granted Mihnea Ovidenie
<mihnea at adobe.com>'s request for review:
Bug 74219: [CSS Regions] Two regions reftests are failing the image match
https://bugs.webkit.org/show_bug.cgi?id=74219
Attachment 179000: Patch 3
https://bugs.webkit.org/attachment.cgi?id=179000&action=review
------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179000&action=review
>
LayoutTests/fast/regions/positioned-objects-block-static-spanning-regions-expec
ted.html:33
> + line-height: 1.25;
> + font-size: 16px;
> + font-family: monospace;
Nit: The shorthand is good to use as it's more compact. Here it would be: font:
16px/1.25 monospace;
Also couldn't it be simplified to: font: 20px/1 monospace? (ie font-size: 20px
and line-height: 1)
More information about the webkit-reviews
mailing list