[webkit-reviews] review denied: [Bug 101274] Allow plugins to be disabled by shared library filename : [Attachment 179036] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has denied Parth Patel
<parpatel at rim.com>'s request for review:
Bug 101274: Allow plugins to be disabled by shared library filename
https://bugs.webkit.org/show_bug.cgi?id=101274

Attachment 179036: Patch
https://bugs.webkit.org/attachment.cgi?id=179036&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179036&action=review


> Source/WebCore/ChangeLog:11
> +	   No new tests are needed.

please explain why

> Source/WebCore/plugins/PluginDatabase.cpp:317
> +    // Skip plugin files that are disabled by filename

dot at end

> Source/WebCore/plugins/PluginDatabase.cpp:383
> +    return m_disabledPluginFiles.add(fileName).isNewEntry

does it build??