[webkit-reviews] review granted: [Bug 103797] [chromium] Minimize memcpy for encoded image data in ImageFrameGenerator : [Attachment 178331] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 12 04:35:50 PST 2012
Stephen White <senorblanco at chromium.org> has granted Hin-Chung Lam
<hclam at google.com>'s request for review:
Bug 103797: [chromium] Minimize memcpy for encoded image data in
ImageFrameGenerator
https://bugs.webkit.org/show_bug.cgi?id=103797
Attachment 178331: Patch
https://bugs.webkit.org/attachment.cgi?id=178331&action=review
------- Additional Comments from Stephen White <senorblanco at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178331&action=review
Looks good. r=me
> Source/WebCore/platform/graphics/chromium/ThreadSafeDataTransport.h:39
> +// The purpose of this class is to allow transferring data stored in
Grammar nit: "transferring" -> "the transfer of"
> Source/WebCore/platform/graphics/chromium/ThreadSafeDataTransport.h:41
> +// SharedBuffer in a thread-safe manner. At the same time minimizing
> +// memory copy and thread contention.
Grammar nit: this is not a sentence. I'd just join it to the previous one:
".. thread-safe manner, and to minimize memory copies and thread contention."
More information about the webkit-reviews
mailing list