[webkit-reviews] review granted: [Bug 104783] [chromium] WebTestPlugin must not depend on WTF::String : [Attachment 179005] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 12 02:10:48 PST 2012


Kent Tamura <tkent at chromium.org> has granted jochen at chromium.org's request for
review:
Bug 104783: [chromium] WebTestPlugin must not depend on WTF::String
https://bugs.webkit.org/show_bug.cgi?id=104783

Attachment 179005: Patch
https://bugs.webkit.org/attachment.cgi?id=179005&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179005&action=review


> Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:108
> +	   snprintf(buffer, sizeof(buffer), "* %d, %d: %s\n",
points[i].position.x, points[i].position.y, pointState(points[i].state));

I'm not sure snprintf is available in Visual Studio.


More information about the webkit-reviews mailing list