[webkit-reviews] review granted: [Bug 104777] Web Inspector: Native Memory Instrumentation: simplify Sequences processing code. : [Attachment 178996] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 12 01:49:10 PST 2012


Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 104777: Web Inspector: Native Memory Instrumentation: simplify Sequences
processing code.
https://bugs.webkit.org/show_bug.cgi?id=104777

Attachment 178996: Patch
https://bugs.webkit.org/attachment.cgi?id=178996&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178996&action=review


> Source/WTF/ChangeLog:8
> +	   Drive by fix: redesign reportMemoryUsage for the sequences.

Drive by?

> Source/WTF/wtf/MemoryInstrumentationSequence.h:39
> +template <typename T> struct IsNotConvertibleType {

IsNotConvertibleType -> NotConvertibleToInteger


More information about the webkit-reviews mailing list