[webkit-reviews] review granted: [Bug 104670] [GTK][AC] GraphicsLayers are not shown on the viewport : [Attachment 178922] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Joone Hur
<joone at webkit.org>'s request for review:
Bug 104670: [GTK][AC] GraphicsLayers are not shown on the viewport
https://bugs.webkit.org/show_bug.cgi?id=104670

Attachment 178922: Patch
https://bugs.webkit.org/attachment.cgi?id=178922&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178922&action=review


LGTM, except for the duplicate timer scheduling.

> Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextClutter.cpp:59
> -    return false;
> +    return true;

This is what we need to implement to render the page contents, right?

> Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextClutter.cpp:93
> +    scheduleLayerFlush();
> +    m_layerFlushTimerCallbackId = g_timeout_add_full(GDK_PRIORITY_EVENTS, 0,
reinterpret_cast<GSourceFunc>(layerFlushTimerFiredCallback), this, 0);

You're scheduling the flush twice here, gotta remove the g_timeout_add_full
call.

> Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextClutter.cpp:132

> -    return FALSE;
> +    return false;

this returns a gboolean, so I'd keep FALSE here