[webkit-reviews] review granted: [Bug 104677] [Qt] Fix the inspector not showing up on Windows : [Attachment 178811] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Jocelyn Turcotte
<jocelyn.turcotte at digia.com>'s request for review:
Bug 104677: [Qt] Fix the inspector not showing up on Windows
https://bugs.webkit.org/show_bug.cgi?id=104677

Attachment 178811: Patch
https://bugs.webkit.org/attachment.cgi?id=178811&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178811&action=review


r=me with a small change :)

> Source/api.pri:24
> +    include(WebCore/WebCore.pri)

I think if you move this whole block until _after_ the load(webkit_modules)
part in api.pri, then you can remove the inclusion of WebCore.pri and therefore
avoid it being included twice (webkit_modules will also include it due to
WEBKIT += webcore)

(WebCore.pri is designed to be included only once, as it does += on LIBS and
other variables instead of *=)