[webkit-reviews] review granted: [Bug 104346] [Shadow DOM] registering InsertionPoints to ShadowRoot should work out of document tree. : [Attachment 178954] Patch

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has granted Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 104346: [Shadow DOM] registering InsertionPoints to ShadowRoot should work
out of document tree.
https://bugs.webkit.org/show_bug.cgi?id=104346

Attachment 178954: Patch
https://bugs.webkit.org/attachment.cgi?id=178954&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=178954&action=review


> Source/WebCore/ChangeLog:9
> +	   out of Document, too. Instead of checking isInDocument(), we have to
check InsertionPoint and

nit: "check if" or "make sure" or something? For this explanation,  you can
center when the registration happens.

> Source/WebCore/html/shadow/InsertionPoint.cpp:130
> +	   if (isActive() && !m_registeredWithShadowRoot &&
insertionPoint->treeScope() == treeScope()) {

Nit: root == treeScope()? In that case, It'd better use root instead of
treeScope() for comparison here.