[webkit-reviews] review denied: [Bug 104347] Coordinated Graphics: Remove the dependency of WebCoordinatedSurface::Handle from Coordinated Graphics. : [Attachment 178932] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 104347: Coordinated Graphics: Remove the dependency of
WebCoordinatedSurface::Handle from Coordinated Graphics.
https://bugs.webkit.org/show_bug.cgi?id=104347

Attachment 178932: Patch
https://bugs.webkit.org/attachment.cgi?id=178932&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178932&action=review


> Source/WebKit2/Shared/CoordinatedGraphics/WebCoordinatedSurface.h:125
> +
> +    // Only WebCoordinatedSurface in Web Process has this member.
> +    OwnPtr<Handle> m_handle;
> +    mutable OwnPtr<WebCore::Timer<WebCoordinatedSurface> >
m_releaseHandleTimer;
> +
> +#ifndef NDEBUG
> +    enum Purpose {
> +	   Producer,
> +	   Consumer
> +    };
> +    // This member exists for only a debugging purpose. It is Producer in
Web Process, while Consumer in UI Process.
> +    Purpose m_purpose;
> +#endif

This is not really needed.
You can do everything else in this patch without having this magically-released
handle.