[webkit-reviews] review denied: [Bug 39725] Dragging over an element with scrollbars should scroll the element when dragging near edges : [Attachment 177950] Patch 2.0-2

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has denied yosin at chromium.org's request for
review:
Bug 39725: Dragging over an element with scrollbars should scroll the element
when dragging near edges
https://bugs.webkit.org/show_bug.cgi?id=39725

Attachment 177950: Patch 2.0-2
https://bugs.webkit.org/attachment.cgi?id=177950&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=177950&action=review


The approach looks good. Let's take this as an opportunity to cleanup
auto-scrolling code.

> Source/WebCore/page/EventHandler.cpp:136
> +// Delay time in second for start autoscroll if pointer is in border edge of
scrollable element.

can be static since it's referred only from this file.

> Source/WebCore/page/EventHandler.cpp:137
> +const double autoscrollDelay = 0.2;

Ditto.

> Source/WebCore/page/EventHandler.cpp:141
> +const int autoscrollBeltSize = 20;

same.