[webkit-reviews] review denied: [Bug 104404] Allow embedder to observe changes to frame names : [Attachment 178283] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Fady Samuel
<fsamuel at chromium.org>'s request for review:
Bug 104404: Allow embedder to observe changes to frame names
https://bugs.webkit.org/show_bug.cgi?id=104404

Attachment 178283: Patch
https://bugs.webkit.org/attachment.cgi?id=178283&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178283&action=review


> Source/WebCore/page/ChromeClient.h:148
> +	   virtual void frameNameChanged(Frame*, const String&) { }

this feels like something that should be plumbed through the FrameLoaderClient

> Source/WebKit/chromium/public/WebViewClient.h:165
> +    virtual void frameNameChanged(WebFrame*, const WebString&) { }

nit: we usually go with a format more like didChangeFoo or willChangeFoo.
it seems like the consistent approach would be didChangeFrameName, but how
about putting this on WebFrameClient instead?  Then, it can just be
didChangeName
as a WebFrame already has a name attribute.