[webkit-reviews] review requested: [Bug 104354] IndexedDB: Don't use strings to represent serialized values : [Attachment 178915] Patch

[bugzilla-daemon at webkit.org]

Michael Pruett <michael at 68k.org> has asked  for review:
Bug 104354: IndexedDB: Don't use strings to represent serialized values
https://bugs.webkit.org/show_bug.cgi?id=104354

Attachment 178915: Patch
https://bugs.webkit.org/attachment.cgi?id=178915&action=review

------- Additional Comments from Michael Pruett <michael at 68k.org>
I've added back WARN_UNUSED_RETURN which I erroneously removed from
IDBBackingStore::putRecord(). I have also eliminated encodeIDBValue() and
decodeIDBValue() and have replaced those with calls to Vector::appendVector()
and Vector::appendRange(). I've also updated IDBBackingStore::Cursor::value()
to return a const Vector<uint8_t>& rather than Vector<uint8_t>. I believe these
changes should eliminate the extra memory copies introduced in my previous
patch.