[webkit-reviews] review granted: [Bug 104681] AX: Make isActionSupported cross-platform. : [Attachment 178846] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Dominic Mazzoni
<dmazzoni at google.com>'s request for review:
Bug 104681: AX: Make isActionSupported cross-platform.
https://bugs.webkit.org/show_bug.cgi?id=104681

Attachment 178846: Patch
https://bugs.webkit.org/attachment.cgi?id=178846&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=178846&action=review


looks good. minor comments you can fix in commit

> Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:678
> +    return [actions containsObject:@"AXPress"];

this should be NSAccessibilityPressAction

> Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:688
> +    return [actions containsObject:@"AXIncrement"];

NSAccessibilityIncrementAction

> Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:698
> +    return [actions containsObject:@"AXDecrement"];

NSAccessibilityDecrementAction

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:686
> +    return [actions containsObject:@"AXPress"];

ditto with the name used

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:696
> +    return [actions containsObject:@"AXIncrement"];

ditto with the name used

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:706
> +    return [actions containsObject:@"AXDecrement"];

ditto with the name used

> LayoutTests/platform/mac/accessibility/slider-supports-actions.html:25
> +	     var succeeded = obj.isIncrementActionSupported() == true;

seems like we have remove these "== true" as they're redundant

> LayoutTests/platform/mac/accessibility/slider-supports-actions.html:28
> +	     var succeeded = obj.isDecrementActionSupported() == true;

seems like we have remove these "== true" as they're redundant

> LayoutTests/platform/mac/accessibility/slider-supports-actions.html:38
> +	     var succeeded = obj.isIncrementActionSupported() == true;

seems like we have remove these "== true" as they're redundant

> LayoutTests/platform/mac/accessibility/slider-supports-actions.html:41
> +	     var succeeded = obj.isDecrementActionSupported() == true;

seems like we have remove these "== true" as they're redundant