[webkit-reviews] review granted: [Bug 104688] AX: accessibilityIsIgnored should avoid computing textUnderElement : [Attachment 178878] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Dominic Mazzoni
<dmazzoni at google.com>'s request for review:
Bug 104688: AX: accessibilityIsIgnored should avoid computing textUnderElement
https://bugs.webkit.org/show_bug.cgi?id=104688

Attachment 178878: Patch
https://bugs.webkit.org/attachment.cgi?id=178878&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=178878&action=review


> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1275
> +    if (isGenericFocusableElement() && node->firstChild())

a comment here of the form
// Make sure that a focusable element has a child to focus onto

or something appropriate would be good