[webkit-reviews] review granted: [Bug 104612] Enhance the TileCache to cache more tiles : [Attachment 178670] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <timothy_horton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 104612: Enhance the TileCache to cache more tiles
https://bugs.webkit.org/show_bug.cgi?id=104612

Attachment 178670: Patch
https://bugs.webkit.org/attachment.cgi?id=178670&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=178670&action=review


Yikes!

> Source/WebCore/ChangeLog:72
> +	   (WebCore::TileCache::TileCache):
> +	   (WebCore::TileCache::~TileCache):
> +	   (WebCore::TileCache::setNeedsDisplay):
> +	   (WebCore::TileCache::setNeedsDisplayInRect):
> +	   (WebCore::TileCache::setTileNeedsDisplayInRect):
> +	   (WebCore::TileCache::setScale):
> +	   (WebCore::TileCache::setAcceleratesDrawing):
> +	   (WebCore::TileCache::setTilesOpaque):
> +	   (WebCore::TileCache::prepopulateRect):
> +	   (WebCore::TileCache::setTileDebugBorderWidth):
> +	   (WebCore::TileCache::setTileDebugBorderColor):
> +	   (WebCore::TileCache::computeTileCoverageRect):
> +	   (WebCore::TileCache::tileSizeForCoverageRect):
> +	   (WebCore::TileCache::tileRevalidationTimerFired):
> +	   (WebCore::TileCache::blankPixelCount):
> +	   (WebCore::queueTileForRemoval):
> +	   (WebCore::TileCache::removeAllTiles):
> +	   (WebCore::TileCache::removeAllSecondaryTiles):
> +	   (WebCore::TileCache::removeTilesInCohort):
> +	   (WebCore::TileCache::revalidateTiles):
> +	   (WebCore::TileCache::nextTileCohort):
> +	   (WebCore::TileCache::startedNewCohort):
> +	   (WebCore::TileCache::newestTileCohort):
> +	   (WebCore::TileCache::oldestTileCohort):
> +	   (WebCore::TileCache::scheduleCohortRemoval):
> +	   (WebCore::TileCache::cohortRemovalTimerFired):
> +	   (WebCore::TileCache::ensureTilesForRect):
> +	   (WebCore::TileCache::tileGridExtent):
> +	   (WebCore::TileCache::tileCoverageRect):
> +	   (WebCore::TileCache::tileLayerAtIndex):
> +	   (WebCore::TileCache::drawTileMapContents):

This saddens the reviewer.

> Source/WebCore/page/FrameView.cpp:1896
> +    fprintf(stderr, "FrameView::requestScrollPositionUpdate to %d,%d\n",
position.x(), position.y());

Is this logging supposed to be here? Seems unlikely.