[webkit-reviews] review granted: [Bug 104643] Mail hangs when resizing the font size of a large RTL text : [Attachment 178746] Resolved conflicts

[bugzilla-daemon at webkit.org]

Enrica Casucci <enrica at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 104643: Mail hangs when resizing the font size of a large RTL text
https://bugs.webkit.org/show_bug.cgi?id=104643

Attachment 178746: Resolved conflicts
https://bugs.webkit.org/attachment.cgi?id=178746&action=review

------- Additional Comments from Enrica Casucci <enrica at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=178746&action=review


Looks good to me. Only few nit picks. Please fix the ASSERT problem before
landing

> Source/WebCore/ChangeLog:19
> +	   (InlineRunToApplyStyle):

Please remove

> Source/WebCore/ChangeLog:21
> +	   (WebCore):

Please remove

> Source/WebCore/ChangeLog:29
> +	   (ApplyStyleCommand):

Ditto

> Source/WebCore/ChangeLog:32
> +	   (StyleChange):

Ditto

> Source/WebCore/editing/ApplyStyleCommand.cpp:719
> +struct InlineRunToApplyStyle {

Why did you choose a struct instead of a class?