[webkit-reviews] review granted: [Bug 104687] check-webkit-style complaining about TestExpectations lines a patch didn't modify : [Attachment 178853] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 104687: check-webkit-style complaining about TestExpectations lines a patch
didn't modify
https://bugs.webkit.org/show_bug.cgi?id=104687

Attachment 178853: Patch
https://bugs.webkit.org/attachment.cgi?id=178853&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
In theory we could fix this properly by having both lines involved in a
duplicate expectation get a lint error? Then we wouldn't lose any coverage
here.

We'd still want line filtering on for that though, right? So this patch is
correct either way, but a FIXME would be nice. It's going to be a pain to keep
the lint-webkitpy step green.