[webkit-reviews] review granted: [Bug 103219] Initialize new web processes with list of auto-start origins for plug-ins : [Attachment 178677] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 11 10:18:52 PST 2012


Anders Carlsson <andersca at apple.com> has granted Jon Lee <jonlee at apple.com>'s
request for review:
Bug 103219: Initialize new web processes with list of auto-start origins for
plug-ins
https://bugs.webkit.org/show_bug.cgi?id=103219

Attachment 178677: Patch
https://bugs.webkit.org/attachment.cgi?id=178677&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=178677&action=review


> Source/WebKit2/UIProcess/Plugins/PlugInAutoStartProvider.cpp:58
> +void PlugInAutoStartProvider::populateCopyOfTable(Vector<unsigned>&
copyVector)
> +{
> +    copyToVector(m_autoStartHashes, copyVector);
> +}

I think you should make this return a Vector<unsigned> instead and give it a
more appropriate name.


More information about the webkit-reviews mailing list