[webkit-reviews] review granted: [Bug 104581] Update MediaSource to allow append() calls in "ended" state. : [Attachment 178809] Rebase

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Aaron Colwell
<acolwell at chromium.org>'s request for review:
Bug 104581: Update MediaSource to allow append() calls in "ended" state.
https://bugs.webkit.org/show_bug.cgi?id=104581

Attachment 178809: Rebase
https://bugs.webkit.org/attachment.cgi?id=178809&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=178809&action=review


> Source/WebCore/Modules/mediasource/MediaSource.cpp:293
> +    if (m_readyState == endedKeyword())
> +	   setReadyState(openKeyword());
>  
>      if (!m_player->sourceAppend(id, data->data(), data->length())) {
>	   ec = SYNTAX_ERR;

Is it necessary to call to m_player->sourceAppend() when data->length() is
zero?

It is probably worth having an explicit test for calling append() with no data
when state is "ended".