[webkit-reviews] review granted: [Bug 104668] [GTK] Soup network logs are frequently interrupted by other logging messages : [Attachment 178793] add custom soup log printer

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Jonathon Jongsma (jonner)
<jonathon at quotidian.org>'s request for review:
Bug 104668: [GTK] Soup network logs are frequently interrupted by other logging
messages
https://bugs.webkit.org/show_bug.cgi?id=104668

Attachment 178793: add custom soup log printer
https://bugs.webkit.org/attachment.cgi?id=178793&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178793&action=review


Thanks!

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:81
> +inline static void soupLogPrinter(SoupLogger *logger, SoupLoggerLogLevel
level, char direction, const char* data, gpointer userData)

Nit: SoupLogger *logger should be SoupLogger* logger and you can omit the
"userData" and "level" here entirely.