[webkit-reviews] review denied: [Bug 103959] Coordinated Graphics: Refactor TiledBackingStore code in CoordinatedGraphicsLayer. : [Attachment 178340] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 103959: Coordinated Graphics: Refactor TiledBackingStore code in
CoordinatedGraphicsLayer.
https://bugs.webkit.org/show_bug.cgi?id=103959

Attachment 178340: Patch
https://bugs.webkit.org/attachment.cgi?id=178340&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178340&action=review


> Source/WebCore/platform/graphics/TiledBackingStore.cpp:50
> +    , m_needToCreateNextTiles(false)

I dont understand this variable

> Source/WebCore/platform/graphics/TiledBackingStore.cpp:191
> -    coverWithTilesIfNeeded();
> +    createTilesIfNeeded();

why this rename, it doesnt delete tiles anymore?

> Source/WebCore/platform/graphics/TiledBackingStore.cpp:330
> +    m_needToCreateNextTiles = requiredTileCount;

m_pendingTileCreation ?

> Source/WebCore/platform/graphics/TiledBackingStore.cpp:333
> +    if (m_needToCreateNextTiles)
> +	   needToCreateTiles();
> +}

it is only called here. Why have the method?

> Source/WebCore/platform/graphics/TiledBackingStore.cpp:338
> +	   m_client->tiledBackingStoreNeedToCreateTiles();

pendingTileCreation?