[webkit-reviews] review granted: [Bug 104462] Switch to new PseudoElement based :before and :after : [Attachment 178634] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Elliott Sprehn
<esprehn at chromium.org>'s request for review:
Bug 104462: Switch to new PseudoElement based :before and :after
https://bugs.webkit.org/show_bug.cgi?id=104462

Attachment 178634: Patch
https://bugs.webkit.org/attachment.cgi?id=178634&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178634&action=review


This looks great.  Thanks.

> Source/WebCore/rendering/RenderObject.h:629
> +    // FIXME: Why does RenderWidget need this?
> +    void clearNode() { m_node = 0; }

It shouldn't.  RenderWidget outlives the Rendering Tree (and Document)
sometimes, as I believe plugins can hold onto it during their teardown?