[webkit-reviews] review denied: [Bug 103237] Performance gain for Animations using CSS 2D transforms while leveraging GPU accelerated compositing : [Attachment 178669] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied cyang.tech at gmail.com's
request for review:
Bug 103237: Performance gain for Animations using CSS 2D transforms while
leveraging GPU accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=103237

Attachment 178669: Patch
https://bugs.webkit.org/attachment.cgi?id=178669&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=178669&action=review


We already accelerated animating 2D transforms. I don't understand what this
patch is trying to do.

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1807
> +#if (CPU(X86) || CPU(X86_64))

We don't use #ifdefs like this. Reading the code, I have no idea what platforms
these are, and why they need to be different.