[webkit-reviews] review granted: [Bug 104570] [Coverity] [GTK] Remove some redundant null checks in DumpRenderTree : [Attachment 178651] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 104570: [Coverity] [GTK] Remove some redundant null checks in
DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=104570

Attachment 178651: Patch
https://bugs.webkit.org/attachment.cgi?id=178651&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178651&action=review


OK. This patch doesn't change the existing functionality. That is, we currently
return an empty string for the NSURLRequest portion of the willSendRequest
string when soupMessage is null. I'm unclear how some ports came to the
decision to return an empty string for the NSURLRequest portion of the
willSendRequest string and some ports return a NSURLRequest string with
"(none)" for the HTTP method.

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1235
> +	   path.data(), mainDocumentURIString.data(), soupMessage->method));

For completeness, the Mac and EFL ports return "(none)" when the HTTP method
isn't known.