[webkit-reviews] review denied: [Bug 104465] [Chromium] Support for Network Information API : [Attachment 178495] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 10 11:20:41 PST 2012


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 104465: [Chromium] Support for Network Information API
https://bugs.webkit.org/show_bug.cgi?id=104465

Attachment 178495: Patch
https://bugs.webkit.org/attachment.cgi?id=178495&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178495&action=review


R- based on Peter Beverloo's comments.

> Source/WebKit/chromium/public/WebViewClient.h:372
> +    virtual WebNetworkInfoClient* networkInfoClient() { return 0; }

WebKit API review notes: Network information is not a per-WebView property, so
it
does not belong on WebViewClient.  There should instead be a Platform-level API

to query network information and to receive an event when network information
changes.


More information about the webkit-reviews mailing list