[webkit-reviews] review denied: [Bug 104538] [Qt] Animation fails on large layers : [Attachment 178576] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has denied Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 104538: [Qt] Animation fails on large layers
https://bugs.webkit.org/show_bug.cgi?id=104538

Attachment 178576: Patch
https://bugs.webkit.org/attachment.cgi?id=178576&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178576&action=review


> Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:475
> +    // We need to paint directly when the dirty rect excedes one of the
maximum dimensions.

exceed

> Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h:89
> +    virtual void getDebugBorderInfo(Color&, float& width) const OVERRIDE;

This doesn't seem to be used.

> Source/WebCore/platform/graphics/texmap/TextureMapperImageBuffer.cpp:65
> +    GraphicsContext* context = m_image->context();
> +
> +    IntRect sourceRect(targetRect);
> +    sourceRect.setLocation(sourceOffset);
> +    context->translate(targetRect.x() - sourceOffset.x(), targetRect.y() -
sourceOffset.y());
> +    sourceLayer->paintGraphicsLayerContents(*context, sourceRect);

You probably want to clear the rect before you paint directly into it.

> Source/WebCore/platform/graphics/texmap/TextureMapperImageBuffer.h:29
> +static const int s_maximumAllowedImageBufferDimension = 4096;

Can this be inside the function, or in a CPP file?