[webkit-reviews] review requested: [Bug 104369] [GTK] Expose HitTestResult::scrollbar() condition in API : [Attachment 178550] new patch correcting the ChangeLog

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 10 07:40:45 PST 2012


Eduardo Lima Mitev <elima at igalia.com> has asked  for review:
Bug 104369: [GTK] Expose HitTestResult::scrollbar() condition in API
https://bugs.webkit.org/show_bug.cgi?id=104369

Attachment 178550: new patch correcting the ChangeLog
https://bugs.webkit.org/attachment.cgi?id=178550&action=review

------- Additional Comments from Eduardo Lima Mitev <elima at igalia.com>
>> Source/WebKit2/ChangeLog:18
>> +	    - Adds a new bool 'isScrollbar' to WebHitTestResult to
>> +	      carry the scrollbar() condition from Web process to UI process.
>> +	    - Adds a new flag WEBKIT_HIT_TEST_RESULT_CONTEXT_SCROLLBAR to
>> +	      WebKitHitTestResult context enum.
>> +	    - Adds the corresponding accessor context_is_scrollbar() to
>> +	      WebKitHitTestResult.
>> +	    - Adds the corresponding unit test cases to
>> +	      '/webkit2/WebKitWebView/mouse-target'.

> Please, move these below adding per function explanations instead. Sorry,
> that I didn't notice this in the previous patch.

New patch fixing this.


More information about the webkit-reviews mailing list