[webkit-reviews] review denied: [Bug 104538] [Qt-Directfb] Animation causes a crash with www.tuenti.com : [Attachment 178533] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has denied Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 104538: [Qt-Directfb] Animation causes a crash with www.tuenti.com
https://bugs.webkit.org/show_bug.cgi?id=104538

Attachment 178533: Patch
https://bugs.webkit.org/attachment.cgi?id=178533&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178533&action=review


This would bring back the "old" performance issue with drawing text several
times if it falls on the border between tiles...
We should only do this in the case of large dirtyRects.

> Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.h:98
> +    void updateContents(TextureMapper*, GraphicsLayer*, const FloatSize&,
const IntRect&, BitmapTexture::UpdateContentsFlag);

This function doesn't seem right. I don't like passing all these
responsibilities to TextureMapperTile.
I prefer that GraphicsLayerTextureMapper perform all the painting; and if we
need to use something like a "Client" approach here.

> Source/WebCore/platform/graphics/texmap/TextureMapperImageBuffer.h:68
> +    virtual IntSize maxTextureSize() const { return IntSize(2048, 2048); }

Seems arbitrary, an enum with some explicit name could help...