[webkit-reviews] review granted: [Bug 104550] [Qt] MediaPlayerQTKit broken after switching QPainter to raster engine. : [Attachment 178539] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Zeno Albisser
<zeno at webkit.org>'s request for review:
Bug 104550: [Qt] MediaPlayerQTKit broken after switching QPainter to raster
engine.
https://bugs.webkit.org/show_bug.cgi?id=104550

Attachment 178539: Patch
https://bugs.webkit.org/attachment.cgi?id=178539&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178539&action=review


r=me with comments/changes.

Looking forward to this code path disappearing altogether hopefully in the near
future ;-)

> Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:1374
> +    NSBitmapImageRep *imageRep = [[NSBitmapImageRep alloc]
initWithBitmapDataPlanes: NULL

I think you're going to need to call [imageRep release] later on after painting
to release the memory again, no?