[webkit-reviews] review granted: [Bug 66371] Web Inspector: ConsoleTypes should not expose MessageType - it should be private to inspector. : [Attachment 177739] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Mike West
<mkwst at chromium.org>'s request for review:
Bug 66371: Web Inspector: ConsoleTypes should not expose MessageType - it
should be private to inspector.
https://bugs.webkit.org/show_bug.cgi?id=66371

Attachment 177739: Patch
https://bugs.webkit.org/attachment.cgi?id=177739&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177739&action=review


Overall looks good. Please make sure xenon is fine with removing messagetype
from Apple webkit ports. AFAIR it was only used in toString form there, so
nothing should break.

> Source/WebCore/inspector/InspectorConsoleTypes.h:1
> +/*

This one could be called ConsoleAPITypes

> Source/WebCore/page/Console.cpp:232
> +    internalAddMessage(page(), LogMessageType, ErrorMessageLevel, state,
arguments, shouldPrintExceptions());

I only see call sites that use page() as a first argument, why did this change?