[webkit-reviews] review granted: [Bug 104529] [Qt] Builds for Mac are tied to the OS system instead of the SDK version. : [Attachment 178509] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Michael Brüning
<michael.bruning at digia.com>'s request for review:
Bug 104529: [Qt] Builds for Mac are tied to the OS system instead of the SDK
version.
https://bugs.webkit.org/show_bug.cgi?id=104529

Attachment 178509: Patch
https://bugs.webkit.org/attachment.cgi?id=178509&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178509&action=review


> Source/WebCore/WebCore.pri:188
> +	       SYSTEM_LIBRARY_PATH =
$${ROOT_WEBKIT_DIR}/WebKitLibraries/libWebKitSystemInterfaceLeopard.a
> +	   } else:contains(QMAKE_MAC_SDK, ".*MacOSX10.6.sdk.*") {
> +	       SYSTEM_LIBRARY_PATH =
$${ROOT_WEBKIT_DIR}/WebKitLibraries/libWebKitSystemInterfaceSnowLeopard.a
> +	   } else:contains(QMAKE_MAC_SDK, ".*MacOSX10.7.sdk.*") {

I think references to Leopard and SnowLeopard can be removed before landing.
These libraries do not exist anymore (see WebKitLibraries/). Only Lion and
MountainLion are supported in trunk.