[webkit-reviews] review granted: [Bug 91727] [GTK][jhbuild] Switch to GStreamer 1.0 build : [Attachment 177518] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has granted Xabier Rodríguez Calvar
<calvaris at igalia.com>'s request for review:
Bug 91727: [GTK][jhbuild] Switch to GStreamer 1.0 build
https://bugs.webkit.org/show_bug.cgi?id=91727

Attachment 177518: Patch
https://bugs.webkit.org/attachment.cgi?id=177518&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=177518&action=review


Looks good, just two small nits to fix before landing.

> configure.ac:819
> +GSTREAMER_1_0_REQUIRED_VERSION=0.11.90
> +GSTREAMER_1_0_PLUGINS_BASE_REQUIRED_VERSION=0.11.90

Should be 1.0.3

> configure.ac:853
> +   AC_DEFINE([GST_USE_UNSTABLE_API], [1], [Using unstable GStreamer API])

That should be removed.