[webkit-reviews] review denied: [Bug 104003] WebKit tests for the Qt API should include tests of CMake config files : [Attachment 177483] Add unit test

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied steveire at gmail.com's request
for review:
Bug 104003: WebKit tests for the Qt API should include tests of CMake config
files
https://bugs.webkit.org/show_bug.cgi?id=104003

Attachment 177483: Add unit test
https://bugs.webkit.org/attachment.cgi?id=177483&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Patch looks good in general, but please include a ChangeLog.

You can do this for example by calling

Tools/Scripts/webkit-patch prepare 104003

The number is the number of this bug, so that the ChangeLog will automatically
include a reference to this bug.
After calling this command, open the ChangeLog changed files and complete the
new entries. Afterwards you can post your patch automatically to bugzilla by
using

Tools/Scripts/webkit-patch post

and you can pass --request-commit as parameter to the post command if you'd
like to get the patch landed automatically using the commit queue. (you
probably want this unless you are a committer yourself or you know somebody how
is going to care of landing the change in SVN)