[webkit-reviews] review denied: [Bug 102794] Fix QNX Qt build by enabling JIT. : [Attachment 177325] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 10 01:32:55 PST 2012
Simon Hausmann <hausmann at webkit.org> has denied Sergio Martins
<sergio.martins at kdab.com>'s request for review:
Bug 102794: Fix QNX Qt build by enabling JIT.
https://bugs.webkit.org/show_bug.cgi?id=102794
Attachment 177325: Patch
https://bugs.webkit.org/attachment.cgi?id=177325&action=review
------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=177325&action=review
> Source/WTF/wtf/Platform.h:900
> + && !(OS(QNX) && !PLATFORM(QT)) // We use jit in qnx qt
jit -> JIT. qnx -> QNX. qt -> Qt
And the use of C++ comments in this header file breaks the build of any C
files, as the Gtk EWS indicated.
More information about the webkit-reviews
mailing list