[webkit-reviews] review denied: [Bug 103366] [TexMap] Refactor TextureMapperLayer::flushCompositingState(). : [Attachment 178471] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 103366: [TexMap] Refactor TextureMapperLayer::flushCompositingState().
https://bugs.webkit.org/show_bug.cgi?id=103366

Attachment 178471: Patch
https://bugs.webkit.org/attachment.cgi?id=178471&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178471&action=review


You're also removing the SyncOptions thingy... it's ok but you need to specific
in the changelog why/how this is ok.

> Source/WebCore/ChangeLog:11
> +	   urrently, CoordinatedGraphicsLayer performs layer tree traversal by
> +	   itself, but GraphicsLayerTextureMapper delegates the tree traversal
to
> +	   TextureMapperLayer. This patch decides the tree traversal is the
role of
> +	   GraphicsLayer.

Perform the layer-tree traversal in GraphicsLayerTextureMapper.

> Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:420
> +	  
toGraphicsLayerTextureMapper(maskLayer())->flushCompositingState(rect);

you don't need toGraphicsLayerTextureMapper