[webkit-reviews] review granted: [Bug 103663] [Mac] Add support for in-band text tracks : [Attachment 178101] Rebased again.

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Eric Carlson <eric.carlson at apple.com>'s
request for review:
Bug 103663: [Mac] Add support for in-band text tracks
https://bugs.webkit.org/show_bug.cgi?id=103663

Attachment 178101: Rebased again.
https://bugs.webkit.org/attachment.cgi?id=178101&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178101&action=review


> Source/WebCore/platform/graphics/MediaPlayer.h:65
> -class TextTrackClient;
> +class ScriptExecutionContext;

I don't understand this change. It is also a layering violation.

>
Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cp
p:827
> +	   RefPtr<InbandTextTrackPrivateAVF>(track) = m_textTracks[i];

That's a bit wacky.  I am surprised that does anything.

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.h:68
> +    void processCue(NSArray *, Float64);

Is Float64 different than double?

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:1226
> +	       RefPtr<InbandTextTrackPrivateAVF>(track) =
static_cast<InbandTextTrackPrivateAVF*>(m_textTracks[i].get());

Weird syntax again.

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:1237
> +	   RefPtr<InbandTextTrackPrivateAVF>(track) =
static_cast<InbandTextTrackPrivateAVF*>(m_textTracks[i].get());

Weird syntax again.