[webkit-reviews] review granted: [Bug 104406] JSC should scale the optimization threshold for a code block according to the cost of compiling it : [Attachment 178397] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 9 12:14:23 PST 2012


Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 104406: JSC should scale the optimization threshold for a code block
according to the cost of compiling it
https://bugs.webkit.org/show_bug.cgi?id=104406

Attachment 178397: the patch
https://bugs.webkit.org/attachment.cgi?id=178397&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=178397&action=review


r=me

> Source/JavaScriptCore/profiler/ProfilerDatabase.cpp:61
> +    Bytecodes* result = addBytecodes(
> +	   codeBlock->hash(), codeBlock->sourceCodeForTools());

something this short could just be a single line :p


More information about the webkit-reviews mailing list