[webkit-reviews] review requested: [Bug 104483] Wrong Enabled states on a ListBox : [Attachment 178417] Fixes the bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 9 07:34:26 PST 2012


Alejandro Piñeiro <apinheiro at igalia.com> has asked  for review:
Bug 104483: Wrong Enabled states on a ListBox
https://bugs.webkit.org/show_bug.cgi?id=104483

Attachment 178417: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=178417&action=review

------- Additional Comments from Alejandro Piñeiro <apinheiro at igalia.com>
The error was at AccessibilityListBoxOption, as it redefined isEnabled, and
didn't take into account the DISABLED attribute. So this patch takes that into
account, and for completeness sake, I also added a check for aria-disabled. I
renamed the test, as this is a listbox specif thing, and also added
aria-atribute checks.

As you could have noticed, I also removed the [GTK] prefix at the summary and
moved it to the Accessibility component. This is because taking into account
the solution, this problem would be affecting any port.


More information about the webkit-reviews mailing list