[webkit-reviews] review granted: [Bug 101074] [GTK] Use a private struct and placement new syntax in GObject DOM bindings : [Attachment 177776] New patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 9 02:17:35 PST 2012


Xan Lopez <xan.lopez at gmail.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 101074: [GTK] Use a private struct and placement new syntax in GObject DOM
bindings
https://bugs.webkit.org/show_bug.cgi?id=101074

Attachment 177776: New patch
https://bugs.webkit.org/attachment.cgi?id=177776&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
This looks good. I'd just put a comment somewhere explaining why we do the
Object parent class thing, and noting that this works now because the classes
we care about happen to be direct subclasses of Object. That way people
changing this code in the future will have a chance to get it right ;)

(Also, 'constructed' and the signal handling all seem to be garbage code from
the old event listener era, we can remove that in a follow-up patch)


More information about the webkit-reviews mailing list