[webkit-reviews] review denied: [Bug 104423] [JSC] Add tests for explicit serialization values : [Attachment 178372] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 8 13:30:07 PST 2012


Dirk Pranke <dpranke at chromium.org> has denied  review:
Bug 104423: [JSC] Add tests for explicit serialization values
https://bugs.webkit.org/show_bug.cgi?id=104423

Attachment 178372: Patch
https://bugs.webkit.org/attachment.cgi?id=178372&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
JSC isn't a platform, so it feels wrong to me to put this stuff under
LayoutTests/platform. I suggest just using LayoutTests/jsc and modifying
platform/chromium/TestExpectations to include a line like "jsc [ WontFix ]".

In particular, we don't want to modify default_baseline_search_path() to
include "platform/jsc" at all, since it's not part of the search path in the
sense of the other platform dirs.


More information about the webkit-reviews mailing list